Skip to content
Ameen Abozaid
MID-066

Technical collaboration

  • 6 Lessons
  • 2 h practice (estimate)
On this page 8 topics

Overview

Topics

  • Reviews
  • constructive feedback
  • mentoring junior engineers

Learn first

2 h of practice (estimate)

Learning outcomes

  1. Review code for correctness, design, and operability, with comments that teach.
  2. Give and receive feedback on designs constructively.
  3. Mentor a junior engineer through pairing and well-scoped tasks.
  4. Disagree and commit, escalating only when needed.

Lessons

  1. 01Reviewing beyond style
  2. 02Feedback that lands
  3. 03Design reviews
  4. 04Mentoring juniors
  5. 05Disagreement and decisions
  6. 06Demo: reviewing a real pull request out loud

Lab and exercises

Lab

MID-066-LAB1 · Mentor and review

Outcomes: 1–4 · Time: ~2 h

  1. Review two Junior-level capstone pull requests with labeled, teaching comments.
  2. Pair with a Junior learner on one fix; let them drive.
  3. Collect feedback from the mentee on how helpful the pairing was.
  4. Write a short note on one disagreement you handled and how it was resolved.

Acceptance: reviews scored on usefulness; mentee feedback collected.

Exercises (assessment: review-quality rubric; five exercises)

IDOutcomeTask
MID-066-EX011Review a 60-line diff with a hidden race condition and a missing timeout; write labeled comments.
MID-066-EX022Rewrite five harsh or vague review comments so they are specific, kind, and actionable.
MID-066-EX032Prepare a design review of a one-page design: list your ten questions and what feedback the author should request.
MID-066-EX043Write a well-scoped task brief for a junior to add input validation to one endpoint.
MID-066-EX054Two engineers disagree on cache versus read replica. Write a neutral summary for the decider.
Show solutions
  • EX01 blocking: shared mutable state without synchronization, with a failing test idea; blocking: call without timeout (MID-023); question: what if the list is empty; one praise.
  • EX02 For example "bad naming" becomes "data hides what it holds; pendingOrders would say it. suggestion:".
  • EX03 Questions on problem, constraints, alternatives, failure modes, load, rollout, rollback, observability, security, cost; the author asks for feedback on risks and alternatives.
  • EX04 Goal, links to patterns, acceptance (tests for valid and invalid input), one hint, stuck limit of 30 minutes, review time.
  • EX05 Context, options with trade-offs (freshness, complexity, cost), measurements to take, recommendation if any, decision date.

Quiz

Outcomes: O1 reviewing code · O2 feedback and design reviews · O3 mentoring · O4 disagree and commit.

A self-check for you: nothing is graded, saved or sent anywhere. Choose an answer, then check it. You can try again as often as you like.

  1. 1Human reviewers should mainly focus on:O1
  2. 2A mistake in reviewing:O1
  3. 3A comment that rewrites the author's whole method is:O1
  4. 4The label nit: means:O2
  5. 5Good feedback is:O2
  6. 6In a design review the author should begin with:O2
  7. 7When pairing with a junior:O3
  8. 8A well-scoped task for a junior has:O3
  9. 9"Disagree and commit" means:O4
  10. 10Escalate a disagreement when:O4

Practical part

Five exercises MID-066-EX01 to EX05 plus the lab. Pass: at least four exercises correct and reviews scoring at least "useful" on the rubric with mentee feedback collected.

Common mistakes

Rewriting the author's code in comments; approving without reading tests.

Assessment

Review-quality rubric.

Career relevance

Mentorship (SRC-020) and technical influence at every senior level.

Type to search levels, phases, modules and lessons.