Code review as reviewer and author
On This Lesson 4 topics
This lesson is planned. The outline below lists the topics it will cover. The full lesson has not been published yet.
In this lesson
give and receive feedback well.
Planned topics
- Reviewers check correctness, tests, clarity, and risks first; style comes last (tools can check style).
- Comment on the code, not the person; ask questions: "What happens if the cart is empty?"
- Mark comments as blocking or optional (nit).
- Authors: assume good intent, respond to every comment, and explain or change.
- Approve when it is good enough, not perfect; follow up later for minor ideas.
Draft outline details
Demonstration
two comments: "This is wrong" versus "This will fail for an empty list; could we add a test for it?"
Check your understanding
Which comments should a reviewer raise first, correctness or formatting?
Show answer
Correctness.
Practice
Apply this lesson with the module's lab, exercises and quiz.
Marking a lesson complete is optional and you can undo it any time. Your progress stays in this browser.